-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dg/bypass-finals to the conflict packages list #1605
Conversation
composer.json
Outdated
@@ -67,7 +67,8 @@ | |||
"webmozart/path-util": "^2.3" | |||
}, | |||
"conflict": { | |||
"phpunit/php-code-coverage": ">9 <9.1.4" | |||
"phpunit/php-code-coverage": ">9 <9.1.4", | |||
"dg/bypass-finals": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dg/bypass-finals": "*" | |
"dg/bypass-finals": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, please run composer update --lock
to fix
- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run
composer update
orcomposer update <package name>
.
I feel like this is a conflict for |
yes and no. Someone should still be able to use interceptor (for whatever reason) without Infection, even if they use bypass-finals. So let's add it here for now just to avoid Infection's users time waste. I really hope we will soon revert it if bypass-finals's author answers to me here dg/bypass-finals#9 (comment) |
This PR adds the library dg/bypass-finals to the conflict section of composer.json file since infection and bypass-finals aren't compatibles yet.
Related to #1275